Add lsp-ivy-document-symbol #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzmatazz
commented
Oct 1, 2022
| ;; Keywords: languages, debug | ||
| ;; URL: https://github.com/emacs-lsp/lsp-ivy | ||
| ;; Package-Requires: ((emacs "25.1") (dash "2.14.1") (lsp-mode "6.2.1") (ivy "0.13.0")) | ||
| ;; Package-Requires: ((emacs "27.1") (dash "2.14.1") (lsp-mode "6.2.1") (ivy "0.13.0")) |
There was a problem hiding this comment.
27.1 is required for flatten-tree -- I can probably drop it and rewrite it differently if needed
jcs090218
approved these changes
Oct 1, 2022
yyoncho
reviewed
Oct 1, 2022
| "`ivy' for lsp textDocument/documentSymbol." | ||
| (interactive) | ||
| (let* ((xs (lsp-request-while-no-input "textDocument/documentSymbol" | ||
| (lsp--text-document-position-params))) |
There was a problem hiding this comment.
I don't think you should use this method. IMHO it should be async and it should let the user type while the query runs.
|
|
||
|
|
||
|
|
||
| (lsp-defun lsp-ivy--format-document-symbol-match (dsym) |
There was a problem hiding this comment.
You may handle deprecated as well. And using lsp-defun does not make sense if you don't destructure in the params.
Consider integrating with treemacs icons (you may check for lsp-treemacs and use the helpers from there).
Consider optionally adding the possibility to indicate the parent/child relation using identation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation of
lsp-ivy-document-symbol; at some point I got frustrated with imenu and how it behaves (at least to what I have on doom emacs) and figured I might do something about this.This might need more love, testing and feedback to get up to a good quality, but I already have support for both DocumentSymbol and SymbolInformation (older LSP servers) as response from
textDocument/documentSymbol.