[DONT MERGE] proposal: rewrote colorscheme to Lua

[DrKJeff16]

Description

Caution

@skbolton
THIS IS A PROPOSAL

I have rewritten the colorscheme to Lua. My proposal here is to either split this into a new branch OR (prefferably) create a new port.

I'm new to making colorschemes specifically, so I'd like to know what you think.

Setup is now changed. I'll use lazy.nvim as an example:

{
    'embark-theme/vim',
    lazy = false,
    priority = 1000,
    name = 'embark',
    config = function()
        require('embark').setup({ italic = false }) -- This is all I have set up thus far
        vim.cmd.colorscheme('embark')
    end,
}

[skbolton]

I have gone back and forth on this many times. I personally would love to have the theme in lua for the improved ergonomics of developing the theme. It really comes down to the cost of splitting the project. If this were to happen than it would need to be a new nvim port. But than you will end up a lot of people that never upgrade and stay stuck in the old vim package. At this point I haven't gone for it since there wasn't anything I couldn't do using the vim package. Let me think on this for a bit.

[DrKJeff16]

A less... conventional alternative may be like nvim-treesitter did, albeit under very different circumstances.

That is an interesting approach, although work could still continue on the vim port since it wouldn't be deprecated. If the two branches would end up looking entirely different and users would have to change their package manager in some way either way I sm still leaning on a different repo for neovim.

[skbolton]

Apologies @DrKJeff16 I went to copy your message to quote on what you said but then accidentally edited your message..... I don't know why github allows you to edit other people's messages.....

[DrKJeff16]

Apologies @DrKJeff16 I went to copy your message to quote on what you said but then accidentally edited your message..... I don't know why github allows you to edit other people's messages.....

Haha. That still counts as a response.

---

That is an interesting approach, although work could still continue on the vim port since it wouldn't be deprecated. If the two branches would end up looking entirely different and users would have to change their package manager in some way either way I sm still leaning on a different repo for neovim.

@skbolton Oh don't get me wrong, I'd also prefer another repo instead.

Speaking of another repo, if you need any help with setting it up/maintenance for it I'm willing to do it. Ofc your decisions would be final and I'll look into any suggestions. I'd rather do Lua stuff than Vimscript myself. ¹²³

Footnotes

1. https://github.com/DrKJeff16/project.nvim ↩

2. https://github.com/DrKJeff16/wezterm-types ↩

3. https://github.com/p00f/clangd_extensions.nvim ↩