Skip to content

[tsgen] Fix memory64 with pthreads TS generation. #24630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

brendandahl
Copy link
Collaborator

We already lower memory64 away when running TS generation, but we were not generating a lowered version of the JS which caused us to try and use a BigInt when creating the memory.

Fixes #24623

We already lower memory64 away when running TS generation, but we were
not generating a lowered version of the JS which caused us to try and
use a BigInt when creating the memory.

Fixes emscripten-core#24623
@brendandahl brendandahl requested review from kripken and sbc100 June 27, 2025 23:08
@brendandahl brendandahl force-pushed the tsgen-pthread-mem64 branch from e999555 to 41fabf3 Compare June 30, 2025 23:33
@brendandahl brendandahl merged commit 31a6f1e into emscripten-core:main Jul 1, 2025
25 of 30 checks passed
@brendandahl
Copy link
Collaborator Author

Oops, I had the wrong fixed issue number. Fixes #24620

# v24, so we need to lower it away in order to execute the binary at build
# time.
# TODO Remove lowering when emsdk version of node is >= 24 and just require it.
if settings.MEMORY64:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be == 1 there and below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] --emit-tsd Fails in Debug Builds with Multiple Binding Files Using Same Module Name
3 participants