Move createWasm call from python to JS template. NFC
#24940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
move_createWasm
branch
from
7c7ed6d to
c2ca244
Compare
sbc100
force-pushed
the
move_createWasm
branch
from
c2ca244 to
623be6b
Compare
kripken
approved these changes
Aug 15, 2025
sbc100
force-pushed
the
move_createWasm
branch
3 times, most recently
from
eec42fe to
eb8594c
Compare
We should always prefer JS template code to python-generated JS (IMHO).
sbc100
force-pushed
the
move_createWasm
branch
from
eb8594c to
25a5c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always prefer JS template code to python-generated JS (IMHO).