Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

allow iterate over custom num of records #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow iterate over custom num of records #473

wants to merge 1 commit into from

Conversation

Mng-dev-ai
Copy link
Contributor

Closes #413

ansipunk
ansipunk reviewed Jan 3, 2023
View reviewed changes
databases/backends/aiopg.py
@@ -179,7 +179,7 @@ async def execute_many(self, queries: typing.List[ClauseElement]) -> None:
cursor.close()

async def iterate(
self, query: ClauseElement
self, query: ClauseElement, n: int = None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n: Optional[int] = None

databases/backends/aiopg.py
@@ -195,6 +195,10 @@ async def iterate(
Row._default_key_style,
row,
)
if n is not None:
n -= 1
if n == 0:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use if n <= 0 in case if negative n was passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ansipunk ansipunk ansipunk left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: iterate over more than 1 record
2 participants
@Mng-dev-ai @ansipunk