Skip to content

Conversation

dhaval-mehta
Copy link
Contributor

#7264 was reverted by mistake.

This is another merge request with identical changes.

@carltongibson
Copy link
Collaborator

It wasn’t reverted by mistake. There was a test failure on master. 😀

The tests failed on the original PR, but the test run didn’t finish, so Travis didn’t report, and I didn’t notice.

Let’s see what happens here, as I was able to reproduce the failure locally.

@dhaval-mehta
Copy link
Contributor Author

My bad. 😞
I had some uncommitted changes in the local repository which caused the failure of test cases in the master branch.
Now, I have pushed that remaining code and test cases are passed. 😃

@dhaval-mehta
Copy link
Contributor Author

dhaval-mehta commented Apr 29, 2020

@carltongibson Can you please assign the 3.12 release milestone on this merge request?

@stale
Copy link

stale bot commented Mar 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 29, 2022
@auvipy auvipy added the Bug label Nov 29, 2022
@stale stale bot removed the stale label Nov 29, 2022
@auvipy auvipy closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants