Skip to content

Conversation

@x-Diego64-x
Copy link

Minigame 2 is in progress; it just needs some textures added and the continuity of the map regression and the connection with minigame 3 improved

@x-Diego64-x x-Diego64-x requested a review from a team as a code owner November 14, 2025 14:09
@github-actions
Copy link

Play this branch at https://play.threadbare.game/branches/Game-Lab-5-0-UTP-Group-4-Team-5/diego.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq
Copy link
Collaborator

manuq commented Nov 14, 2025

Whoa very dark! I like the player holding a flashlight, and how they grab it at the beginning.

image

@manuq manuq added the StoryQuest New StoryQuests or updates to existing ones label Nov 14, 2025
Copy link
Collaborator

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Please improve the submission according to this guide

In particular:

  • The Title field should briefly mention what is included in the StoryQuest, and is ideally written in English.
  • The Description should include a brief outline of the work included in the PR. As the story quest content is added to the game via the PRs, this should include what concepts/stories it is built around and what are the main gameplay elements. It is OK to submit this in Spanish. Attribution sections titled as Assets, Engineering, Game Design, and Production & Management. These should reference GitHub usernames of the contributors.

Check how this other team is doing it: #1561

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a global scenes/globals/camera_shaker/camera_shake.gd and a generic shaker node scenes/game_elements/fx/shaker/Shaker.tscn. Do you really need your own script? Ideally you should be reusing our systems.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these 2 lines at the top of every script. Otherwise the license check fails.

Suggested change
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
extends Area2D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
extends CharacterBody2D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
extends CharacterBody2D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
extends Camera2D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

StoryQuest New StoryQuests or updates to existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants