-
Notifications
You must be signed in to change notification settings - Fork 216
Minigame 2 - beta #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minigame 2 - beta #1586
Conversation
Duplicate and rename template files of somnus
creacion de mapa en intro y outro
Intro de Somnnus
intro beta 1 :)
minijuego 1 beta 1 :)
minijuego 1 beta 2
|
Play this branch at https://play.threadbare.game/branches/Game-Lab-5-0-UTP-Group-4-Team-5/diego. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. Please improve the submission according to this guide
In particular:
- The Title field should briefly mention what is included in the StoryQuest, and is ideally written in English.
- The Description should include a brief outline of the work included in the PR. As the story quest content is added to the game via the PRs, this should include what concepts/stories it is built around and what are the main gameplay elements. It is OK to submit this in Spanish. Attribution sections titled as Assets, Engineering, Game Design, and Production & Management. These should reference GitHub usernames of the contributors.
Check how this other team is doing it: #1561
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a global scenes/globals/camera_shaker/camera_shake.gd and a generic shaker node scenes/game_elements/fx/shaker/Shaker.tscn. Do you really need your own script? Ideally you should be reusing our systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these 2 lines at the top of every script. Otherwise the license check fails.
| # SPDX-FileCopyrightText: The Threadbare Authors | |
| # SPDX-License-Identifier: MPL-2.0 | |
| extends Area2D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # SPDX-FileCopyrightText: The Threadbare Authors | |
| # SPDX-License-Identifier: MPL-2.0 | |
| extends CharacterBody2D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # SPDX-FileCopyrightText: The Threadbare Authors | |
| # SPDX-License-Identifier: MPL-2.0 | |
| extends CharacterBody2D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # SPDX-FileCopyrightText: The Threadbare Authors | |
| # SPDX-License-Identifier: MPL-2.0 | |
| extends Camera2D |

Minigame 2 is in progress; it just needs some textures added and the continuity of the map regression and the connection with minigame 3 improved