Skip to content

Conversation

pedro2s
Copy link
Contributor

@pedro2s pedro2s commented Mar 19, 2025

@epiphone
When I came across the same problem reported in this issue
#30 I took the initiative to implement @JamesMcFall 's suggestion and to help other developers who are having the same problem, I leave my contribution

Copy link
Owner

@epiphone epiphone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests.

@pedro2s pedro2s requested a review from epiphone April 2, 2025 17:26
@pedro2s
Copy link
Contributor Author

pedro2s commented Apr 9, 2025

Needs tests.

Tests added.

@bladerunner2020
Copy link

I hope this feature will be added soon, as it's a must-have when minification is in use.

@pedro2s
Copy link
Contributor Author

pedro2s commented Aug 12, 2025

Needs tests.

added

@pedro2s pedro2s closed this Aug 12, 2025
@pedro2s pedro2s reopened this Aug 12, 2025
Copy link
Owner

@epiphone epiphone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please address the remaining comments and make sure CI passes and we'll get this shipped.

pedro2s and others added 3 commits August 18, 2025 09:08
Co-authored-by: Aleksi Pekkala <aleksipekkala@gmail.com>
Co-authored-by: Aleksi Pekkala <aleksipekkala@gmail.com>
@pedro2s
Copy link
Contributor Author

pedro2s commented Aug 18, 2025

Thank you! Please address the remaining comments and make sure CI passes and we'll get this shipped.

Resolved!

@pedro2s pedro2s requested a review from epiphone August 18, 2025 12:29
@epiphone epiphone merged commit 54325c8 into epiphone:master Aug 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants