Fix: Correctly Pass GH_TOKEN to Application in Docker #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WzDTj
changed the title
WzDTj
changed the title
|
I think this should be fixed here, but let me know if it doesnt :) |
Yes, this issue has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a critical issue where the GH_TOKEN was not being correctly parsed when the application runs within a Docker container.
The previous Dockerfile used the exec form of the CMD instruction to start the application, which looked like this:
CMD ["start", "-g", "$GH_TOKEN"]The reason this approach fails is fundamental to how Docker operates: the
execform ofCMDdoes not run the command inside a command shell.The value passed to the application for the
-gflag was not the actual content of theGH_TOKENvariable. Instead, the application received the literal, un-expanded string$GH_TOKEN, which is not a valid token and therefore caused authentication to fail.