Skip to content

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Sep 19, 2025

As @jessebraham spotted, in #882 we reverted the way detect_chip work, to rely again on the magic value instead of chip security info, which should be the preferred way (#814). In this PR:

  • I moved all the security info stuff to the connection module (its where its used) although we have to reexport it and keep a "stub" method in flasher struct to avoid breaking changes (those could be deleted in the next major), also this helps in Untangle Flasher code, that isn't related to flashing. #793
  • When detecting a chip, we try to use the securtiy info, if that doesnt work/chip doesnt have it, we fallback to the magic value

@SergioGasquez SergioGasquez marked this pull request as draft September 19, 2025 08:33
@SergioGasquez SergioGasquez force-pushed the fix/detect-chip branch 2 times, most recently from 98d05fb to 1efccec Compare September 19, 2025 08:43
@SergioGasquez SergioGasquez marked this pull request as ready for review September 19, 2025 08:53
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev enabled auto-merge September 19, 2025 13:13
@SergioGasquez SergioGasquez force-pushed the fix/detect-chip branch 2 times, most recently from 1e18c35 to 106997d Compare September 22, 2025 10:59
@SergioGasquez SergioGasquez force-pushed the fix/detect-chip branch 3 times, most recently from 88257f9 to 8ccda22 Compare September 23, 2025 09:08
@MabezDev MabezDev added this pull request to the merge queue Sep 23, 2025
Merged via the queue into esp-rs:main with commit f8a344f Sep 23, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants