spotrem: add volume knob gesture #3847
Conversation
|
Very cool! Works well when I tested it. Do you think it's worth mentioning that the clockwise/anticlockwise gesture detection is stopped after a brief period of no-interaction? Not for this PR, but if you wanted ideas on going further with this feature, it'd be cool to pull it out to a library and let other apps opt into the clockwise gesture, and during the clockwise gesture, display a circle on screen that follows the user's gesture. But obviously those are much bigger changes! |
|
Thanks :)
Yes! Will add that.
Yes - that's where I started with this. But I switched to this focused implementation first to dial in the UX (pun intended). |
Only the drag gesture functionality provided. I intend to add a companion module providing some relevant graphics, sharing the same options object.
|
@bobrippling this is maybe done now! Please comment any feedback you may have :) It now adds two new modules for dial functionality, one for touch interaction and one for graphics. This is used in |
| if (isFill) g.fillCircle(x, y, rad); | ||
| } | ||
| if (this.isFirstDraw) { | ||
| g.setColor(0,0,0).fillCircle(CENTER.x, CENTER.y, 25); |
There was a problem hiding this comment.
I guess the radii for the drawing operations should not be hardcoded to 25, 23, 9 etc but depend on the DIAL_RECT...
Can be tried at: https://thyttan.github.io/BangleApps/?id=spotrem
Edit:
Adds two new modules for dial functionality, one for touch interaction and one for graphics. This is used in
spotremto provide the volume knob.