Skip to content

[widalarmeta] Add option to only show when on clock #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2025

Conversation

thinkpoop
Copy link
Contributor

Link: https://thinkpoop.github.io/BangleApps/?id=widalarmeta

Adds an option to the Alarm ETA widget to only show when on the clock face.

I started using a widget to show the time when not on a clock. This way I see the alarm ETA when on the clock and the current time when not on the clock.

Copy link
Collaborator

@bobrippling bobrippling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change - one little request

Co-authored-by: Rob Pilling <robpilling@gmail.com>
@thinkpoop thinkpoop marked this pull request as draft August 6, 2025 15:35
@thinkpoop thinkpoop marked this pull request as ready for review August 6, 2025 16:39
@@ -59,5 +60,14 @@
writeSettings();
}
},
/*LANG*/'When To Show': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to wanting this renamed to "Only on clock" or similar and then have it as a regular boolean setting with the standard checkbox formatting. Something to consider for a future update maybe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I wasn't sure if some future person might want a "Not On Clock", but didn't add that to avoid unused features.

@thyttan
Copy link
Collaborator

thyttan commented Aug 10, 2025

I left a comment on this settings entry - please consider 🙏

But I'll merge this as is now 🌞 thanks!

@thyttan thyttan merged commit c13b57a into espruino:master Aug 10, 2025
1 check passed
@bobrippling
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants