Fix #365 #437
Open
Fix #365 #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… necessary; improve tests
|
@Constellation can you please review this, when you have time? |
|
CI is failing on |
|
@michaelficarra could you please take a look at this PR? |
added 9 commits
January 14, 2021 11:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #365 (maybe more).
Changes:
Fixes wrong code generation when using comments in
return,throwand arrow function expressions.add tests
the trailing comments are still the same (incorrect placement), but they do not affect the syntax (can be addressed in a future PR)
blank line preservation: seems no new problems with this
This PR is a continuation of PR #425