[3.5] backport #17176 fix learner metric incorrect issue

[YaoC]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Backport #17176 to release-3.5

Fix #17175

[k8s-ci-robot]

Hi @YaoC. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[YaoC]

I'm trying to backport #17176 but I found that the e2e test code for release-3.5 and release-3.4 is quite different from the one in the main branch. Should I first backport the corresponding e2e framework or rewrite a new e2e case? Any suggestions? @ahrtr @serathius

[ahrtr]

In general, we need to evaluate it case by case. My thought on this are:

• We can try to backport the test framework and common utilities. But if it (backporting) needs huge effort, It's also accepted to directly implement some utilities (e.g. WaitLeader) in 3.5 and 3.4 if it just needs minor effort
• It's open to discussion. cc @jmhbnz @serathius @fuweid @amit-rastogi

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YaoC
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment