Skip to content

[release-3.4] Bump Go to 1.23.10 #20166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

hwdef
Copy link
Contributor

@hwdef hwdef commented Jun 12, 2025

Part of: #20126

@k8s-ci-robot
Copy link

Hi @hwdef. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jun 12, 2025

/ok-to-test

@hwdef
Copy link
Contributor Author

hwdef commented Jun 12, 2025

/retest

Signed-off-by: hwdef <hwdefcom@outlook.com>
@hwdef hwdef force-pushed the release34-bump-go-12310 branch from f254d5d to bea134d Compare June 12, 2025 10:05
@hwdef
Copy link
Contributor Author

hwdef commented Jun 12, 2025

upgrade golang.org/x/net to 0.38.0, because:

 Vulnerability #1: GO-2025-3595
    Incorrect Neutralization of Input During Web Page Generation in x/net in
    golang.org/x/net
  More info: https://pkg.go.dev/vuln/GO-2025-3595
  Module: golang.org/x/net
    Found in: golang.org/x/net@v0.36.0
    Fixed in: golang.org/x/net@v0.38.0 

@hwdef
Copy link
Contributor Author

hwdef commented Jun 12, 2025

It looks like pull-etcd-govulncheck uses go version 1.24

 Vulnerability #3: GO-2025-3749
    Usage of ExtKeyUsageAny disables policy validation in crypto/x509
  More info: https://pkg.go.dev/vuln/GO-2025-3749
  Standard library
    Found in: crypto/x509@go1.24.3
    Fixed in: crypto/x509@go1.24.4
    Example traces found:
      #1: clientv3/credentials/credentials.go:84:31: credentials.transportCredential.ServerHandshake calls credentials.tlsCreds.ServerHandshake, which eventually calls x509.Certificate.Verify 

Is there any way to make it use go1.23

@ivanvc
Copy link
Member

ivanvc commented Jun 13, 2025

Hi @hwdef, we found the issue and fixed it with kubernetes/test-infra#34990. cc. @abdurrehman107, @joshjms.

/retest

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jun 13, 2025

@hwdef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-govulncheck bea134d link true /test pull-etcd-govulncheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc ivanvc mentioned this pull request Jun 13, 2025
19 tasks
@ivanvc
Copy link
Member

ivanvc commented Jun 14, 2025

/test pull-etcd-govulncheck-release-branches

@hwdef
Copy link
Contributor Author

hwdef commented Jun 14, 2025

Hi @hwdef, we found the issue and fixed it with kubernetes/test-infra#34990. cc. @abdurrehman107, @joshjms.

/retest

Thanks a lot!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 077cdcf into etcd-io:release-3.4 Jun 14, 2025
22 checks passed
@hwdef hwdef deleted the release34-bump-go-12310 branch June 16, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants