[release-3.5] Add test-release makefile target

[abdurrehman107]

This PR adds test-release makefile target for release-3.5.

ref: kubernetes/test-infra#32754

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdurrehman107
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joshjms]

/retest

[joshjms]

I think the vulnerability check failure is related to this. Let's wait for the go version bump.

Edit: watching #20164

[joshjms]

/retest

[joshjms]

/test pull-etcd-integration-4-cpu-amd64

[joshjms]

/test pull-etcd-integration-1-cpu-amd64

[joshjms]

/test pull-etcd-integration-2-cpu-amd64

[ivanvc]

Thanks for the pull request, @abdurrehman107. Please rebase your branch due to #20164.

[ivanvc]

/retest

[ivanvc]

/test pull-etcd-integration-1-cpu-amd64

[abdurrehman107]

/test pull-etcd-integration-1-cpu-amd64

[ivanvc]

Thanks for the pull request, @abdurrehman107. Please review my comment. Also, I'd like to suggest running the make targets you're adding locally to ensure that they work (as we haven't enabled them in the CI yet).

[abdurrehman107]

/test pull-etcd-integration-1-cpu-amd64

[k8s-ci-robot]

@abdurrehman107: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-integration-1-cpu-amd64	6cc2289	link	true	/test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[joshjms]

The integration test results show a race condition. In the Github Actions workflow, we run the integration test with the race flag disabled.

linux-integration-1-cpu)
  make install-gofail
  GOARCH=${{ inputs.arch }} CPU=1 RACE='false' FAILPOINTS='true' make test-integration
  ;;

However, in the Prow job, we also check for the race conditions. Would it be better to disable the race flag for release-3.5 to keep the original behavior?

/cc @serathius @jmhbnz

[serathius]

Failure is in ./contrib/raftexample, test-integration should not run those tests. All integration tests are located in ./tests/integration

[ivanvc]

@serathius, do you suggest, then, deleting this function altogether?

etcd/test.sh

Lines 106 to 113 in 75357ec

	function integration_extra {
	if [ -z "${PKG}" ] ; then
	run_for_module "." go_test "./contrib/raftexample" "keep_going" : -timeout="${TIMEOUT:-5m}" "${RUN_ARG[@]}" "${COMMON_TEST_FLAGS[@]}" "$@" || return $?
	run_for_module "tests" go_test "./integration/v2store/..." "keep_going" : -tags v2v3 -timeout="${TIMEOUT:-5m}" "${RUN_ARG[@]}" "${COMMON_TEST_FLAGS[@]}" "$@" || return $?
	else
	log_warning "integration_extra ignored when PKG is specified"
	fi
	}

Which is called from integration_pass:

etcd/test.sh

Lines 115 to 119 in 75357ec

	function integration_pass {
	local pkgs=${USERPKG:-"./integration/..."}
	run_for_module "tests" go_test "${pkgs}" "parallel" : -timeout="${TIMEOUT:-15m}" "${COMMON_TEST_FLAGS[@]}" "${RUN_ARG[@]}" "$@" || return $?
	integration_extra "$@"
	}

[serathius]

@serathius, do you suggest, then, deleting this function altogether?

Hmm, we dropped running raftexample in integration testing in #14881
I think the reasoning was that we were moving raft to separate repo and we expected that raftexample will be moved there too. Unfortunately that didn't happen due to lack of contributions.

I think it's ok to remove it, because we don't test it on release-3.6 nor main branch and we don't have plan to fix race condition in raftexample.

[serathius]

/cc @ahrtr