[Antithesis] Configuration for 1 node cluster #20176
Conversation
joshjms
force-pushed
the
antithesis-config-cluster-size-1
branch
2 times, most recently
from
2166eba to
0536d03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 162 files with indirect coverage changes @@ Coverage Diff @@
## main #20176 +/- ##
==========================================
- Coverage 69.27% 60.08% -9.19%
==========================================
Files 413 395 -18
Lines 34364 32458 -1906
==========================================
- Hits 23805 19502 -4303
- Misses 9160 11414 +2254
- Partials 1399 1542 +143 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
joshjms
force-pushed
the
antithesis-config-cluster-size-1
branch
from
0536d03 to
d5be61b
Compare
joshjms
changed the title
| @@ -105,6 +110,7 @@ func runTraffic(ctx context.Context, lg *zap.Logger, tf traffic.Traffic, hosts [ | |||
| } | |||
| g := errgroup.Group{} | |||
| startTime := time.Since(baseTime) | |||
| fmt.Printf("%v\n", hosts) | |||
There was a problem hiding this comment.
Please remove or use zap.Logger to write logs.
There was a problem hiding this comment.
Noted, I missed this. Will remove!
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package config |
There was a problem hiding this comment.
Didn't expect config to be a Go package.
There was a problem hiding this comment.
Will it be better if it's in the commons package?
There was a problem hiding this comment.
But the Dockerfile and docker-compose files should be moved to config directory.
There was a problem hiding this comment.
I'll handle that in the other PR, I think it will be easier once we finish this yup!
joshjms
force-pushed
the
antithesis-config-cluster-size-1
branch
from
d5be61b to
1541d60
Compare
Signed-off-by: joshjms <joshjms1607@gmail.com>
joshjms
force-pushed
the
antithesis-config-cluster-size-1
branch
from
1541d60 to
d4a1798
Compare
|
This change looks good, great job! However I started getting This doesn't happen when do the same on master. @joshjms could you look why is so? |
|
I'll take a look into it |
|
I'm not sure how to reproduce that, can I ask for the exact commands used? |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshjms, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: #20112
export CFG_NODE_COUNT=1 make antithesis-build-client-docker-image make antithesis-docker-compose-up make antithesis-run-container-traffic make antithesis-run-container-validation/cc @serathius @nwnt
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.