-
Notifications
You must be signed in to change notification settings - Fork 10.1k
etcdctl: refactor json printing to support custom writers #20177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @kstrifonoff. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Kirill Trifonov <kstrifonoff@gmail.com>
8f2f76b
to
e6be3f3
Compare
/cc @ahrtr |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 148 files with indirect coverage changes @@ Coverage Diff @@
## main #20177 +/- ##
==========================================
+ Coverage 62.67% 69.25% +6.57%
==========================================
Files 401 413 +12
Lines 33292 34367 +1075
==========================================
+ Hits 20867 23802 +2935
+ Misses 10867 9173 -1694
+ Partials 1558 1392 -166 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thx
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, kstrifonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A necessary "pre-change" for #19469.
The
jsonPrinter
struct now includes anio.Writer
field, enabling unit testing of this module.