Remove ProtocolVersions smart contract entirely #17434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Delete core ProtocolVersions contract, interface, and test files - Remove ProtocolVersions from OPContractsManager and IOPContractsManager - Update deployment scripts to remove ProtocolVersions deployment logic - Remove ProtocolVersions assertions from ChainAssertions - Remove protocol version handling from op-node runtime config - Delete protocol versions test file from op-e2e - Clean up unused imports and fix compilation errors This completely removes the ProtocolVersions contract and all related functionality from the codebase while maintaining system functionality. Co-Authored-By: gh.owner.kfichter@oplabs.co <gh.owner.kfichter@oplabs.co>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove remaining ProtocolVersions artifact files and snapshots - Update OPContractsManager version from 3.2.0 to 4.0.0 due to breaking changes - Fix semver lock generation issues - All pre-PR checks now pass successfully Co-Authored-By: gh.owner.kfichter@oplabs.co <gh.owner.kfichter@oplabs.co>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
214
to
+217
| DeploySuperchain.Input({ | ||
| guardian: cfg.superchainConfigGuardian(), | ||
| // TODO: when DeployAuthSystem is done, finalSystemOwner should be replaced with the Foundation Upgrades | ||
| // Safe | ||
| protocolVersionsOwner: cfg.finalSystemOwner(), | ||
| superchainProxyAdminOwner: cfg.finalSystemOwner(), | ||
| paused: false, | ||
| recommendedProtocolVersion: bytes32(cfg.recommendedProtocolVersion()), | ||
| requiredProtocolVersion: bytes32(cfg.requiredProtocolVersion()) | ||
| guardian: cfg.superchainConfigGuardian(), | ||
| paused: false |
There was a problem hiding this comment.
Logic consistency error: The comment describes 'The Superchain system has 1 singleton contract' but then lists '1. The SuperchainConfig contract' suggesting there should be more items. The numbering implies a list but only has one item, creating confusion about the system architecture.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
- Remove ProtocolVersionsAddress from rollup config - Remove ProtocolVersions fields from L1Deployments struct - Remove ProtocolVersions assignments in CreateL1DeploymentsFromContracts - All pre-commit checks now pass Co-Authored-By: gh.owner.kfichter@oplabs.co <gh.owner.kfichter@oplabs.co>
|
Closing due to inactivity for more than 7 days. Configure here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ProtocolVersions smart contract entirely
Summary
This PR completely removes the
ProtocolVersionssmart contract and all related functionality from the Optimism repository. The ProtocolVersions contract was previously used to manage superchain protocol version information (required and recommended versions), but is being removed entirely.Key changes:
ProtocolVersions.sol,IProtocolVersions.sol, and associated testsprotocolVersionsimmutable field and constructor parameterop-nodeReview & Testing Checklist for Human
Notes
Session details: Requested by gh.owner.kfichter@oplabs.co
Link to Devin run: https://app.devin.ai/sessions/af5872289edb4b0888c4ebf3cab9b90b