-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: add tests for min-base-fee #17441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+630
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2025
wlawt
commented
Sep 14, 2025
geoknee
reviewed
Sep 15, 2025
geoknee
reviewed
Sep 15, 2025
* add kurtosis files * move dsl into test * passing * ensure block is progressing * remove checkfordecrease func * simulate txs * nits + simplify * base + jovian sysgo passes * sysext passes
wlawt
commented
Sep 15, 2025
/ci authorize 9b29a68 |
geoknee
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 1: actions tests.
geoknee
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2: Acceptance test
geoknee
reviewed
Sep 16, 2025
wlawt
commented
Sep 16, 2025
* wip * pin teku version
/ci authorize d5af502 |
/ci authorize 5a4c2db |
geoknee
reviewed
Sep 16, 2025
/ci authorize f544551 |
This was
linked to
issues
Sep 16, 2025
geoknee
approved these changes
Sep 16, 2025
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 16, 2025
7bd99c9
69 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #16852
Minimal changes to get e2e and acceptance-tests working
Progress:
op-e2e/actions/proofs/jovian_activation_test.go
passesjust acceptance-test "" jovian
passesjust acceptance-test "" base
passesjust acceptance-test simple jovian
now compiles & passesNotes:
TestMinBaseFee
takes longer than the rest of the tests to run on sysgo: 2m32.358s