Skip to content

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Sep 15, 2025

Description

Adds a hint to provide context of historical block hash lookups.

This is a less invasive approach to #16151 because this version uses a higher-level hint, specific to looking up the specific block hash rather than a generic hint that storage proof is required. The advantage is we don't need to rewrite how the lookup is done and can still call the EVM function to perform the lookup rather than reading the storage entry directly.

Tests

Updated unit tests to confirm the hint is emitted.

Metadata

Part of #17416

@ajsutton ajsutton requested review from a team as code owners September 15, 2025 00:52
@ajsutton ajsutton requested a review from mbaxter September 15, 2025 00:52
Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's pretty swell to keep fast_canon mostly untouched.

@ajsutton ajsutton enabled auto-merge September 17, 2025 00:04
@ajsutton ajsutton added this pull request to the merge queue Sep 17, 2025
Merged via the queue into develop with commit a7f11a1 Sep 17, 2025
66 checks passed
@ajsutton ajsutton deleted the aj/block-hash-lookup-hint branch September 17, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants