-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: opcm creator pattern integrate addGameType for v2 games #17464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stevennevins
wants to merge
12
commits into
snevin/issue-17257/creator-pattern-opcm-deploy
Choose a base branch
from
snevins/issue-17260/creator-pattern-opcm-addGameType
base: snevin/issue-17257/creator-pattern-opcm-deploy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: opcm creator pattern integrate addGameType for v2 games #17464
stevennevins
wants to merge
12
commits into
snevin/issue-17257/creator-pattern-opcm-deploy
from
snevins/issue-17260/creator-pattern-opcm-addGameType
+400
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
375d774
to
4ee1e4b
Compare
91ccb5b
to
41c046d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## snevin/issue-17257/creator-pattern-opcm-deploy #17464 +/- ##
==================================================================================
- Coverage 95.94% 95.91% -0.04%
==================================================================================
Files 113 113
Lines 5179 5189 +10
==================================================================================
+ Hits 4969 4977 +8
- Misses 210 212 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
efe73f6
to
fa911d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the v2 creator pattern games into OPCM and validates the behavior behind a feature flag
Tests
Adds tests to validate the behavior for addGameType in both states for the feature flag toggle
Additional context
N/A
Metadata
Closes #17260