fix: resolve race condition in ThrottleController.Update method #17476
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in ThrottleController.Update by changing RLock to Lock
The Update method was using RLock to read strategy reference, then calling
strategy.Update() without holding the lock. This created a race condition
where SetStrategy could change the strategy between reading the reference
and using it, leading to inconsistent throttling behavior.
Using Lock instead of RLock ensures the entire Update operation is atomic,
preventing SetStrategy from modifying the strategy while Update executes.
This guarantees thread safety when controller type is changed at runtime.