Skip to content

event: using slices.Index in std lib #32429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

event: using slices.Index in std lib #32429

wants to merge 1 commit into from

Conversation

cuiweixie
Copy link
Contributor

No description provided.

@cuiweixie cuiweixie requested a review from fjl as a code owner August 13, 2025 16:35
rjl493456442
rjl493456442 reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code and new cold are fundamentally equivalent.

I would prefer to keep it as now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuiweixie @rjl493456442