Skip to content

core/rawdb: enhance database key construction #32431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2025
Merged

core/rawdb: enhance database key construction #32431

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0f04bd
core: opt storageHistoryIndexBlockKey
cuiweixie Aug 14, 2025
a829144
core/rawdb: refactor storageHistoryIndexKey and accountHistoryIndexBl…
cuiweixie Aug 15, 2025
08ee6b4
Delete core/rawdb/schema_test.go
rjl493456442 Aug 15, 2025
2b098e1
Update schema.go
rjl493456442 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions core/rawdb/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,19 @@ func accountHistoryIndexBlockKey(addressHash common.Hash, blockID uint32) []byte

// storageHistoryIndexBlockKey = StateHistoryStorageBlockPrefix + addressHash + storageHash + blockID
func storageHistoryIndexBlockKey(addressHash common.Hash, storageHash common.Hash, blockID uint32) []byte {
var buf [4]byte
binary.BigEndian.PutUint32(buf[:], blockID)
return append(append(append(StateHistoryStorageBlockPrefix, addressHash.Bytes()...), storageHash.Bytes()...), buf[:]...)
var buf4 [4]byte
binary.BigEndian.PutUint32(buf4[:], blockID)

totalLen := len(StateHistoryStorageBlockPrefix) + len(addressHash) + len(storageHash) + 4
out := make([]byte, totalLen)

off := 0
off += copy(out[off:], StateHistoryStorageBlockPrefix)
off += copy(out[off:], addressHash.Bytes())
off += copy(out[off:], storageHash.Bytes())
copy(out[off:], buf4[:])

return out
}

// transitionStateKey = transitionStatusKey + hash
Expand Down
22 changes: 22 additions & 0 deletions core/rawdb/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package rawdb

import (
"math/rand"
"testing"

"github.com/ethereum/go-ethereum/common"
)

var sink []byte

func BenchmarkStorageHistoryIndexBlockKey(b *testing.B) {
var h1, h2 common.Hash
for i := range h1 {
h1[i] = byte(rand.Intn(256))
h2[i] = byte(rand.Intn(256))
}
b.ResetTimer()
for i := 0; i < b.N; i++ {
sink = storageHistoryIndexBlockKey(h1, h2, uint32(i))
}
}
Loading