-
Notifications
You must be signed in to change notification settings - Fork 838
Replace ethers with viem in vm examples/tests
#4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
gabrocheleau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I generally guess we can take this in. I don't want to take in this very old |
etherscurrently is using an older version of@noble/hashes(v1.3.2) which is causing some duplication of versions of@noble/hashesin our monorepo.ethersis only being used invmfor some ABI encoding/decoding utilities in 2 examples and one test so this replaces it withviemwhich has no dependencies and provides basically drop-in replacements for those tools.Note, the robots wrote the actual translations of these functions and I reviewed/edited/tightened things up.