#77 Replace deprecated connection-with-timezone (#82)

Author: kaklakariada

doc/changes/changes_1.0.8.md

@@ -8,6 +8,16 @@ This release adapts the driver to Metabase v0.50.36.
 
 The driver now supports Metabase feature `:describe-fks`. This allows Metabase to retrieve metadata about Foreign Key Constraints from Exasol.
 
+Also the driver now replaces the deprecated method `sql-jdbc.execute/connection-with-timezone` with `sql-jdbc.execute/do-with-connection-with-options`. This will allow using the driver with later Metabase versions and avoids the following warning in the Metabase log:
+
+```
+WARN sql-jdbc.execute :: connection-with-timezone is deprecated in Metabase 0.47.0. Implement do-with-connection-with-options instead.
+```
+
 ## Features
 
 * #78: Upgraded to Metabase v0.50.36
+
+## Bugfixes
+
+* #77: Replace deprecated method `sql-jdbc.execute/connection-with-timezone`

src/metabase/driver/exasol.clj

@@ -157,25 +157,21 @@
         (.execute stmt set-timezone-sql)
         (log/tracef "Successfully set timezone for Exasol to %s using statement %s" timezone-id set-timezone-sql)))))
 
-;; Same as default implementation but without calling the unsupported setHoldability() method
-(defmethod sql-jdbc.execute/connection-with-timezone :exasol
-  [driver database ^String timezone-id]
-  (let [conn (.getConnection (sql-jdbc.execute/datasource-with-diagnostic-info! driver database))]
-    (try
-      (sql-jdbc.execute/set-best-transaction-level! driver conn)
-      (set-time-zone! conn timezone-id)
-      (try
-        (.setReadOnly conn true)
-        (catch Throwable e
-          (log/warn e (trs "Error setting connection to read-only"))))
-      (try
-        (.setAutoCommit conn false)
-        (catch Throwable e
-          (log/warn e (trs "Error setting connection to autoCommit false"))))
-      conn
-      (catch Throwable e
-        (.close conn)
-        (throw e)))))
+(defmethod sql-jdbc.execute/do-with-connection-with-options :exasol
+  [driver db-or-id-or-spec {:keys [session-timezone], :as options} f]
+  (sql-jdbc.execute/do-with-resolved-connection driver db-or-id-or-spec options
+   (fn [^java.sql.Connection conn]
+     (sql-jdbc.execute/set-best-transaction-level! driver conn)
+     (set-time-zone! conn session-timezone)
+     (try
+       (.setReadOnly conn true)
+       (catch Throwable e
+         (log/warn e (trs "Error setting connection to read-only"))))
+     (try
+       (.setAutoCommit conn false)
+       (catch Throwable e
+         (log/warn e (trs "Error setting connection to autoCommit false"))))
+     (f conn))))
 
 (defn- trunc-date
   "Truncate a date, e.g.: