Skip to content
Draft
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9dfee0a
Initial plan
Copilot Aug 11, 2025
2395dcf
Update Stripe.net from 47.4.0 to 48.0.2 and fix breaking changes
Copilot Aug 11, 2025
b32732f
Merge branch 'main' into copilot/fix-1937
niemyjski Aug 25, 2025
b2479a2
Fix Stripe.net v48 breaking changes: handle nullable UnitAmount and c…
Copilot Aug 25, 2025
ea39f39
Merge branch 'main' into copilot/fix-1937
niemyjski Aug 26, 2025
1f13ded
Fix remaining Stripe.net v48 breaking changes: Invoice.Paid, Invoice.…
Copilot Aug 26, 2025
25a00e2
Apply code review suggestions: use String.Equals for status compariso…
Copilot Aug 26, 2025
b0bc8c4
Fix InvoiceLineItem.Price property access for Stripe.net v48 compatib…
Copilot Aug 26, 2025
77a7c41
Fix InvoiceLineItem property access for Stripe.net v48 - remove Price…
Copilot Aug 28, 2025
80a9faf
Attempt to fix InvoiceLineItem.Price access using separate PriceServi…
Copilot Aug 28, 2025
048364e
Attempt to fix Stripe.net v48 line item Price property access with ex…
Copilot Aug 28, 2025
539e0ef
Use reflection to explore InvoiceLineItem properties and fallback to …
Copilot Aug 28, 2025
ba014dc
Implement full reflection-based approach for Price property access in…
Copilot Aug 28, 2025
c07716a
Remove reflection-based approach and use direct Price property access…
Copilot Aug 28, 2025
56f2daa
Update Stripe.net to v49.0.0 and fix breaking API changes
Copilot Oct 21, 2025
56a1efd
Use C# 12 collection expression syntax for cleaner initialization
Copilot Oct 21, 2025
faa6d3c
Fix v49 breaking change: Discount.Coupon moved to Discount.Source.Coupon
Copilot Oct 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 63 additions & 28 deletions src/Exceptionless.Web/Controllers/OrganizationController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,13 @@ public async Task<ActionResult<Invoice>> GetInvoiceAsync(string id)
{
var client = new StripeClient(_options.StripeOptions.StripeApiKey);
var invoiceService = new InvoiceService(client);
stripeInvoice = await invoiceService.GetAsync(id);

// In Stripe.net v48, expand to include all necessary price information
var options = new InvoiceGetOptions
{
Expand = new List<string> { "lines", "lines.data.price" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there consts for this or documentation link/url

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expansion approach was removed in the v49 update (56f2daa) as it doesn't work with the new Stripe.net API structure. Instead, we now fetch Price objects directly using PriceService when needed. The InvoiceLineItem.Price property was completely removed in v49, so expansion doesn't help.

};
stripeInvoice = await invoiceService.GetAsync(id, options);
}
catch (Exception ex)
{
Expand Down Expand Up @@ -247,43 +253,72 @@ public async Task<ActionResult<Invoice>> GetInvoiceAsync(string id)
{
var item = new InvoiceLineItem { Amount = line.Amount / 100.0m, Description = line.Description };

// In Stripe.net v48, the Price object property was removed from InvoiceLineItem
// Try to find alternative ways to access price information
// Try to access price information in multiple ways for Stripe.net v48 compatibility
try
{
// Log available properties for debugging (in development only)
if (_logger.IsEnabled(LogLevel.Debug))
{
var properties = line.GetType().GetProperties().Select(p => p.Name);
_logger.LogDebug("Available InvoiceLineItem properties: {Properties}", string.Join(", ", properties));
}

// Try to get price ID from possible alternative properties
string? priceId = null;

// Check if there's a Plan property (fallback for legacy scenarios)
var planProperty = line.GetType().GetProperty("Plan");
if (planProperty is not null)
// First, try the expanded Price property using reflection (safe for v48)
var priceProperty = line.GetType().GetProperty("Price");
if (priceProperty is not null)
{
var plan = planProperty.GetValue(line);
if (plan is not null)
var price = priceProperty.GetValue(line);
if (price is not null)
{
var planIdProperty = plan.GetType().GetProperty("Id");
if (planIdProperty is not null)
var priceIdProperty = price.GetType().GetProperty("Id");
var nicknameProperty = price.GetType().GetProperty("Nickname");
var unitAmountProperty = price.GetType().GetProperty("UnitAmount");
var recurringProperty = price.GetType().GetProperty("Recurring");

if (priceIdProperty is not null)
{
priceId = planIdProperty.GetValue(plan) as string;
var priceId = priceIdProperty.GetValue(price) as string;
var nickname = nicknameProperty?.GetValue(price) as string;
var unitAmount = unitAmountProperty?.GetValue(price) as long?;

string planName = nickname ?? _billingManager.GetBillingPlan(priceId)?.Name ?? priceId ?? "Unknown";

// Get interval from recurring property
string intervalText = "one-time";
if (recurringProperty is not null)
{
var recurring = recurringProperty.GetValue(price);
if (recurring is not null)
{
var intervalProperty = recurring.GetType().GetProperty("Interval");
if (intervalProperty is not null)
{
intervalText = intervalProperty.GetValue(recurring) as string ?? "one-time";
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot never use reflection

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all reflection usage and reverted to direct Price property access with proper invoice expansion. The approach now uses lines.data.price expansion to restore access to Price information without reflection. Fixed in c07716a.

}

var priceAmount = unitAmount.HasValue ? (unitAmount.Value / 100.0) : 0.0;
item.Description = $"Exceptionless - {planName} Plan ({priceAmount:c}/{intervalText})";
}
}
}

// If we have a price ID, try to build the custom description
if (!String.IsNullOrEmpty(priceId))
else
{
var plan = _billingManager.GetBillingPlan(priceId);
if (plan is not null)
// Fallback: Try to access through Plan property (legacy support)
var planProperty = line.GetType().GetProperty("Plan");
if (planProperty is not null)
{
// Use billing manager plan data to construct description
item.Description = $"Exceptionless - {plan.Name} Plan";
var plan = planProperty.GetValue(line);
if (plan is not null)
{
var planIdProperty = plan.GetType().GetProperty("Id");
if (planIdProperty is not null)
{
var priceId = planIdProperty.GetValue(plan) as string;
if (!String.IsNullOrEmpty(priceId))
{
var billingPlan = _billingManager.GetBillingPlan(priceId);
if (billingPlan is not null)
{
item.Description = $"Exceptionless - {billingPlan.Name} Plan";
}
}
}
}
}
}
}
Expand Down