IOPDAL Feature

[RealEdwardS]

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

• I have performed a self-review of my code
• I have added tests for new features and bugfixes
• I have added documentation for new features
• If it is a modifying the libf3d API, I have updated bindings
• If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

• Style checks
• Fast CI
• Coverage cached CI
• Analysis cached CI
• WASM docker CI
• Android docker CI
• macOS Intel cached CI
• macOS ARM cached CI
• Windows cached CI
• Linux cached CI
• Other cached CI

[mwestphal]

Hi @RealEdwardS

Looks like this is ongoing, do not hesitate to ping me here or on discord when you need a review :)

[RealEdwardS]

Fixed and added some material.

Right now I've skipped some supported PDAL types including faux, i3s, memoryview, pgpointcloud, and tindex, since they're not files, but other buffers/mediums?

The gdal has a lot of files it supports, I still need to add all of them if necessary.

Hopefully I'm on the right path, if I am, I'll continue and add some testing.

Thanks :)

[mwestphal]

The gdal has a lot of files it supports, I still need to add all of them if necessary.

Lets only add the one that we test and that makes sense. We dont need to add every single format.

[mwestphal]

Hopefully I'm on the right path, if I am, I'll continue and add some testing.

Let me know when you need a review or want to discuss how to do things :)

[RealEdwardS]

Can you review my current code? I don't think I've missed anything with the implementation, though I haven't touched anything in the .github directory which I assume is used to test and build the plugin.

Thanks

[mwestphal]

reviewed. Lets focus on a few select formats first.

[mwestphal]

will fix #201

[mwestphal]

Hi @RealEdwardS , how is it going ? Do you need any help ?

[RealEdwardS]

Hi @RealEdwardS , how is it going ? Do you need any help ?

Hi. Sorry for the delay. I've cleaned up some of the issues that was pointed out last time. I am currently trying to build f3d with my current progress and right now it's not building with a "Could not find the VTK package with the following required components: IOPDAL." message.

I tried adding an Install PDAL Dependency dir in the .github/actions dir, but it's still failing to build.

[mwestphal]

Could not find the VTK package with the following required components: IOPDAL

You obviously need to enable IOPDAL in your VTK build :)

Lets discuss on discord. https://discord.f3d.app

[mwestphal]

@RealEdwardS let me know if you have any struggle reaching out on discord

[mwestphal]

do you need this ?

[RealEdwardS]

\ci -main

[RealEdwardS]

\ci fast

[RealEdwardS]

\ci -fast

[RealEdwardS]

\ci main

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.31%. Comparing base (a71bfe6) to head (fb4df6d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
+ Coverage   96.29%   96.31%   +0.02%     
==========================================
  Files         134      136       +2     
  Lines       12798    12868      +70     
==========================================
+ Hits        12324    12394      +70     
  Misses        474      474              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.