-
-
Notifications
You must be signed in to change notification settings - Fork 329
Added getters for camera for azimuth, elevation and yaw #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You are modifying libf3d public API! |
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
you can run ci if you want @AbbasReads :) |
@AbbasReads you need to add python bindings |
Need any help moving forward @AbbasReads ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes needed
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
…d python bindings tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes needed
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
+ Coverage 96.29% 96.32% +0.02%
==========================================
Files 134 136 +2
Lines 12721 12881 +160
==========================================
+ Hits 12250 12407 +157
- Misses 471 474 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
assert math.isclose( | ||
az_value, angle, abs_tol=1e-3 | ||
), f"Expected azimuth ~{angle}, got {az_value}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert math.isclose( | |
az_value, angle, abs_tol=1e-3 | |
), f"Expected azimuth ~{angle}, got {az_value}" | |
assert az_value == approx(angle) |
using from pytest import approx
is less noisy than explicitly calling isclose
.
Also there's no need for an handcrafted description because pytest
already does it on failure, for example:
> assert az_value - 1 == approx(angle)
E assert 28.999999999999996 == 30 ± 3.0e-05
E
E comparison failed
E Obtained: 28.999999999999996
E Expected: 30 ± 3.0e-05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay 👍.
Describe your changes
Added getters for camera for azimuth, elevation and yaw, which are calculated on the fly.
Issue ticket number and link if any
#1419
Checklist for finalizing the PR
.github/workflows/versions.json
, I have updatedtimestamp