Skip to content

Conversation

AbbasReads
Copy link

@AbbasReads AbbasReads commented Sep 15, 2025

Describe your changes

Added getters for camera for azimuth, elevation and yaw, which are calculated on the fly.

Issue ticket number and link if any

#1419

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

AbbasReads and others added 9 commits September 15, 2025 22:56
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
@mwestphal
Copy link
Member

you can run ci if you want @AbbasReads :)

@mwestphal
Copy link
Member

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️! You can find them in their respective directories: python, java, webassembly.

@AbbasReads you need to add python bindings

@mwestphal
Copy link
Member

Need any help moving forward @AbbasReads ?

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

AbbasReads and others added 4 commits September 22, 2025 13:06
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
@mwestphal
Copy link
Member

\ci full

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.32%. Comparing base (c64450f) to head (e6303f4).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   96.29%   96.32%   +0.02%     
==========================================
  Files         134      136       +2     
  Lines       12721    12881     +160     
==========================================
+ Hits        12250    12407     +157     
- Misses        471      474       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +118 to +120
assert math.isclose(
az_value, angle, abs_tol=1e-3
), f"Expected azimuth ~{angle}, got {az_value}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert math.isclose(
az_value, angle, abs_tol=1e-3
), f"Expected azimuth ~{angle}, got {az_value}"
assert az_value == approx(angle)

using from pytest import approx is less noisy than explicitly calling isclose.

Also there's no need for an handcrafted description because pytest already does it on failure, for example:

>       assert az_value - 1 == approx(angle)
E       assert 28.999999999999996 == 30 ± 3.0e-05
E         
E         comparison failed
E         Obtained: 28.999999999999996
E         Expected: 30 ± 3.0e-05

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants