Skip to content

perf: monomorfic variables #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: monomorfic variables #801

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
003a4cf
perf: monomorfic variables
cesco69 Oct 8, 2025
d433cda
fix: make const
cesco69 Oct 8, 2025
ca9dbc7
fix: avoid collision
cesco69 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ function buildInnerObject (context, location) {
)
const hasRequiredProperties = requiredProperties.includes(propertiesKeys[0])

let code = 'let value\n'
let code = ''

for (const key of requiredProperties) {
if (!propertiesKeys.includes(key)) {
Expand All @@ -381,15 +381,16 @@ function buildInnerObject (context, location) {
}

const sanitizedKey = JSON.stringify(key)
const value = 'value_' + key.replace(/[^a-zA-Z0-9]/g, '_')
const defaultValue = propertyLocation.schema.default
const isRequired = requiredProperties.includes(key)

code += `
value = obj[${sanitizedKey}]
if (value !== undefined) {
const ${value} = obj[${sanitizedKey}]
if (${value} !== undefined) {
${addComma}
json += ${JSON.stringify(sanitizedKey + ':')}
${buildValue(context, propertyLocation, 'value')}
${buildValue(context, propertyLocation, `${value}`)}
}`

if (defaultValue !== undefined) {
Expand Down Expand Up @@ -570,18 +571,18 @@ function buildArray (context, location) {

functionCode += `
const arrayEnd = arrayLength - 1
let value
let json = ''
`

if (Array.isArray(itemsSchema)) {
for (let i = 0; i < itemsSchema.length; i++) {
const item = itemsSchema[i]
functionCode += `value = obj[${i}]`
const tmpRes = buildValue(context, itemsLocation.getPropertyLocation(i), 'value')
const value = `value_${i}`
functionCode += `const ${value} = obj[${i}]`
const tmpRes = buildValue(context, itemsLocation.getPropertyLocation(i), value)
functionCode += `
if (${i} < arrayLength) {
if (${buildArrayTypeCondition(item.type, 'value')}) {
if (${buildArrayTypeCondition(item.type, value)}) {
${tmpRes}
if (${i} < arrayEnd) {
json += JSON_STR_COMMA
Expand All @@ -596,8 +597,7 @@ function buildArray (context, location) {
if (schema.additionalItems) {
functionCode += `
for (let i = ${itemsSchema.length}; i < arrayLength; i++) {
value = obj[i]
json += JSON.stringify(value)
json += JSON.stringify(obj[i])
if (i < arrayEnd) {
json += JSON_STR_COMMA
}
Expand All @@ -607,7 +607,7 @@ function buildArray (context, location) {
const code = buildValue(context, itemsLocation, 'value')
functionCode += `
for (let i = 0; i < arrayLength; i++) {
value = obj[i]
const value = obj[i]
${code}
if (i < arrayEnd) {
json += JSON_STR_COMMA
Expand All @@ -627,33 +627,33 @@ function buildArrayTypeCondition (type, accessor) {
let condition
switch (type) {
case 'null':
condition = 'value === null'
condition = `${accessor} === null`
break
case 'string':
condition = `typeof value === 'string' ||
value === null ||
value instanceof Date ||
value instanceof RegExp ||
condition = `typeof ${accessor} === 'string' ||
${accessor} === null ||
${accessor} instanceof Date ||
${accessor} instanceof RegExp ||
(
typeof value === "object" &&
typeof value.toString === "function" &&
value.toString !== Object.prototype.toString
typeof ${accessor} === "object" &&
typeof ${accessor}.toString === "function" &&
${accessor}.toString !== Object.prototype.toString
)`
break
case 'integer':
condition = 'Number.isInteger(value)'
condition = `Number.isInteger(${accessor})`
break
case 'number':
condition = 'Number.isFinite(value)'
condition = `Number.isFinite(${accessor})`
break
case 'boolean':
condition = 'typeof value === \'boolean\''
condition = `typeof ${accessor} === 'boolean'`
break
case 'object':
condition = 'value && typeof value === \'object\' && value.constructor === Object'
condition = `${accessor} && typeof ${accessor} === 'object' && ${accessor}.constructor === Object`
break
case 'array':
condition = 'Array.isArray(value)'
condition = `Array.isArray(${accessor})`
break
default:
if (Array.isArray(type)) {
Expand Down