Skip to content

[CDTOOL-1084] ngwaf signals #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

[CDTOOL-1084] ngwaf signals #692

merged 6 commits into from
Jun 13, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1084-ngwaf-singals branch 3 times, most recently from 3fc7668 to 7f5c87e Compare June 9, 2025 18:34
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review June 9, 2025 18:35
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner June 9, 2025 18:35
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1084-ngwaf-singals branch from 7f5c87e to 3045ab9 Compare June 9, 2025 18:40
kpfleming
kpfleming requested changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One outstanding question, which may just need clarification.

@anthony-gomez-fastly anthony-gomez-fastly merged commit ba2c0ef into main Jun 13, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1084-ngwaf-singals branch June 13, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @kpfleming