-
Notifications
You must be signed in to change notification settings - Fork 51
Feature/op version #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maltanar
wants to merge
22
commits into
main
Choose a base branch
from
feature/op_version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/op version #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabs CustomOp instance with the right opset version from protobuf imported opsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for versioned
CustomOp
s in QONNX while maintaining backwards compatibility.Summary
The custom op registration should now look like this:
New code should use
ModelWrapper.get_customop_wrapper
to access wrappers, instead of the oldgetCustomOp
. The new functionModelWrapper.get_customop_wrapper
uses the opset imports in the ONNX file to fetch the correct version of the custom op wrapper, otherwise defaulting to a fallback version specifiable as a parameter.The PR also sets the existing versions of QONNX custom ops to
v1
and the fallback/default values for QONNX ops will return v1 as well, although there is no real versioning yet. The exception is for channels-last operators, which are supposed to mimic the original operator in its opset. For these, the PR uses a specialcustom_op
registration handler that makes it possible to use arbitrary version numbers.More detailed list of changes
get_opset_imports
andget_customop_wrapper
utility functions toModelWrapper
. The latter function should be used instead of the oldgetCustomOp
as it uses the opset imports in the ONNX file to fetch the correct version of the custom op wrapper, otherwise defaulting to a fallback version specificable as a parameter.getCustomOp
:None
to indicate request for a wrapper for the default op version in the registry.{CustomOp}_v{version}
convention, retrieve the highest available version of the wrapper if opset version is specified.test_customop_verison.py
custom_op
registration handler that makes it possible to use arbitrary version numbers.