-
-
Notifications
You must be signed in to change notification settings - Fork 74
fix: Publish destination and build script on Windows #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Publish destination and build script on Windows #1593
Conversation
}, | ||
"files": [ | ||
"dist", | ||
"src" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To deliver the source code to users Git/GitHub should be used. The source files should not exported for a NPM publish.
"import": "./lib/esm/index.js" | ||
}, | ||
"files": [ | ||
"dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dist
directory does not exist and can not be built right now as there is no build script for it.
"format:prettier": "npm run prettier -- --write", | ||
"prettier": "prettier '**/*.{ts,md,json,yml}'", | ||
"build": "npm run build:cjs && npm run build:esm", | ||
"build:cjs": "tsc --sourceRoot https://raw.githubusercontent.com/fb55/css-select/$(git rev-parse HEAD)/src/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL needs to be wrapped in quotation marks to function in Windows+Git Bash.
The recently commited commit 9421ec9 lead to the
lib
directory not being part of the published package anymore, which results in required files not being found and eventually failure.For example when building an Angular application:
A
dist
directory appears to be used to publish:9421ec9#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R26
But it can not be found in any shape or form inside the repository. There is no reference to such a directory in any file. Is there a build script which has not been pushed yet that fails to export the missing files perhaps?