drop: Return sum of kept, not dropped, rolls as result [fixes #12] #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the dropped rolls were summed as the result. Now, the kept rolls are summed instead.
Narrowly focused on fionafibration#12, not on characterizing eg bounds on drop count. Run using `PYTHONPATH=rolldice pytest .` from the project root directory. Assumes pytest and hypothesis have been installed.
|
Looking forward to this fix please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a one-line change to fix.
I made sure it was working using some tests. If you don't want those, feel free to drop that commit before merge.