Skip to content

feat: Cross-linking of news with operators and countries #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented May 31, 2025

Cross-link news, operators and countries. For news, related countries and operators are displayed in the sidebar. For countries and operators, related news are displayed.

A flag is displayed for countries in the sidebar navigation (resolves #105). The PR contains some refactoring to unify all "related" links. The operator and country lists haven been unified.

@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-splitview branch 2 times, most recently from c4b0071 to 310f870 Compare June 1, 2025 13:34
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch 3 times, most recently from 82719d1 to a505cac Compare June 1, 2025 15:05
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review June 1, 2025 15:06
@MoritzWeber0 MoritzWeber0 requested review from therobrob and Copilot June 1, 2025 15:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements cross-linking between news, operators, and countries by adding new front matter keys and updating the related styling. Key changes include adding an "operator" key to operator and news markdown files, introducing "country" and "operator" lists in news items, and refactoring SASS styles to support the unified design.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
content/operator/**/*.md Added an "operator" key in the front matter for operator pages
content/news/**/*.md Added "country" and "operator" keys to link news with operators/countries
assets/sass/styles.scss Updated styling for operator links, added margins and flag styling
assets/sass/sidemenu.scss Refactored related news list styling under the ".o-related" namespace
assets/sass/content.scss Removed global paragraph styling to support localized styling
archetypes/operator/**/*.md Updated operator template to include the ContentBaseName as operator
Comments suppressed due to low confidence (2)

assets/sass/content.scss:31

  • [nitpick] Removing the global paragraph styling may lead to inconsistent text presentation across pages. Consider applying context-specific paragraph styles to ensure consistent appearance.
p { margin-bottom: 3.2rem; text-align: justify; }

assets/sass/styles.scss:113

  • Renaming from '.o-list__link-wrapper' to '.o-related__operator-wrapper > .o-related__list' may impact template references. Verify that all corresponding templates utilize the updated class name to maintain correct styling.
.o-related__operator-wrapper > .o-related__list {

@MoritzWeber0 MoritzWeber0 requested a review from lenderom June 1, 2025 15:09
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch from a505cac to c9121c6 Compare June 1, 2025 15:11
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-splitview branch from 310f870 to ac4de6d Compare June 2, 2025 18:27
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch from c9121c6 to c0bfcbd Compare June 2, 2025 18:28
Base automatically changed from feat/news-splitview to main June 3, 2025 06:42
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch from c0bfcbd to 62b1e3a Compare June 3, 2025 06:47
Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 1725af6
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6840c6202a680d0008fd5dbe
😎 Deploy Preview https://deploy-preview-168--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch from 62b1e3a to e7b5696 Compare June 3, 2025 06:58
@MoritzWeber0 MoritzWeber0 force-pushed the feat/news-crosslinking branch from e7b5696 to 623b4a8 Compare June 3, 2025 20:27
@MoritzWeber0 MoritzWeber0 requested a review from therobrob June 4, 2025 21:43
@therobrob therobrob merged commit 7820d45 into main Jun 4, 2025
7 checks passed
@therobrob therobrob deleted the feat/news-crosslinking branch June 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigation-label in sidemenu
2 participants