refactor: Rewrite parts of image rendering #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MoritzWeber0
commented
Jun 1, 2025
MoritzWeber0
commented
- Add error handling for pictures that are not found
- Use image partial in render-image hook
- Remove unused code
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add error handling for pictures that are not found - Use image partial in render-image hook - Remove unused code
MoritzWeber0
force-pushed
the
refactor/rending-of-images
branch
from
afa7429 to
042e0b8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the image rendering logic by improving error handling, updating the image partial to support an "eager" loading parameter, and removing unused Sass code.
- Switch from using "loadingLazy" to an "eager" flag in image rendering
- Consolidate image resizing logic into a loop over width values in the image partial
- Add a warning when an image resource is not found and update the deployment workflow to treat warnings as fatal
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| layouts/partials/stage.html | Changed image partial parameter from "loadingLazy" to "eager" |
| layouts/partials/image.html | Refactored image resizing logic and updated title attribute usage |
| layouts/_default/_markup/render-image.html | Added error handling for local images with improved fallback logging |
| assets/sass/styles.scss | Removed unused blank lines |
| .github/workflows/deploy.yaml | Added the --panicOnWarning flag to the Hugo deploy command |
Comments suppressed due to low confidence (1)
.github/workflows/deploy.yaml:68
- The addition of the --panicOnWarning flag causes builds to fail on any warnings. Confirm that this behavior is acceptable for your deployment pipeline or consider handling warnings appropriately before failing the build.
--panicOnWarning
lenderom
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.