Skip to content

fix: Always place the copy icon on the right side on mobile #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

MoritzWeber0
Copy link
Member

Instead of having the copy icon directly after the text (which produced some issues with multi-line texts), always place the the copy icon on the right side. It's easier to reach for right-handed people.

Not 100% sure if the link icon is still recognized with a connection to the title, so happy to hear any feedback.

Resolves #49

Was originally approved in #177, but didn't target the correct branch. Here is another attempt to get it to the main branch.

@MoritzWeber0 MoritzWeber0 requested a review from therobrob June 9, 2025 16:41
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 48bcb78
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68470e9cd84cda00085353a7
😎 Deploy Preview https://deploy-preview-188--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob
Copy link
Member

didn't recognized in which branch pr #177 goes 😅 thx for open it again, @MoritzWeber0! :)

@therobrob therobrob merged commit 23ba728 into main Jun 9, 2025
7 checks passed
@therobrob therobrob deleted the fix/copy-icon-mobile branch June 9, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy-Icon Mobile-View
2 participants