Skip to content

chore: Fix strip-only mode issues in Node.js 22.18 #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2025
Merged

chore: Fix strip-only mode issues in Node.js 22.18 #2958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf04c07
fix import syntax issue in Node.js 22.x
lahirumaramba Aug 12, 2025
a129cde
update mocha
lahirumaramba Aug 13, 2025
62baf33
update emulator test path
lahirumaramba Aug 13, 2025
b63e78b
update emulator test path
lahirumaramba Aug 13, 2025
69b4d1f
update emulator test path
lahirumaramba Aug 13, 2025
a92d165
add Node 24.x to CIs
lahirumaramba Aug 13, 2025
d95696a
Trigger Staging
lahirumaramba Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [18.x, 20.x, 22.x, 24.x]

steps:
- uses: actions/checkout@v4
Expand All @@ -30,4 +30,4 @@ jobs:
run: |
npm install -g firebase-tools@11.30.0
firebase emulators:exec --project fake-project-id --only auth,database,firestore \
'npx mocha \"test/integration/{auth,database,firestore}.spec.ts\" --slow 5000 --timeout 20000 --require ts-node/register'
'npx mocha test/integration/auth.spec.ts test/integration/database.spec.ts test/integration/firestore.spec.ts --slow 5000 --timeout 20000 --require ts-node/register'
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
run: |
npm install -g firebase-tools@11.30.0
firebase emulators:exec --project fake-project-id --only auth,database,firestore \
'npx mocha \"test/integration/{auth,database,firestore}.spec.ts\" --slow 5000 --timeout 20000 --require ts-node/register'
'npx mocha test/integration/auth.spec.ts test/integration/database.spec.ts test/integration/firestore.spec.ts --slow 5000 --timeout 20000 --require ts-node/register'

- name: Run integration tests
run: ./.github/scripts/run_integration_tests.sh
Expand Down
Loading
Loading