Skip to content

[Infra] Use strict patch versions for internal podspec dependencies #15049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 27, 2025

This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version.

  • Dependencies using optimistic versioning (~>) are changed to strict versions (e.g., ~> 12.0.0 to 12.0.0).
  • Dependencies already using exact versions pinned to the minor (e.g., 12.0) are changed to pin to the patch version (e.g., 12.0 to 12.0.0).

This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.

Release tooling should handle this without further changes.

This change updates all internal podspec dependencies to use strict versioning, pinned to the patch version.

- Dependencies using optimistic versioning (`~>`) are changed to strict versions (e.g., `~> 12.0.0` to `12.0.0`).
- Dependencies already using exact versions pinned to the minor (e.g., `12.0`) are changed to pin to the patch version (e.g., `12.0` to `12.0.0`).

This ensures that the build process uses exact versions of internal dependencies, preventing potential compatibility issues and providing more precise version control.
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

This change updates all internal podspec dependencies to float to the patch version (e.g., `~> X.Y.Z`).

This allows for more flexibility in patch releases while maintaining stability for minor and major versions, as discussed in the PR feedback.

- Strict versions (e.g., `X.Y.Z`) are changed to `~> X.Y.Z`.
- Minor-pinned versions (e.g., `X.Y` or `~> X.Y`) are changed to `~> X.Y.0`.
- Patch-pinned optimistic versions (e.g., `~> X.Y.Z`) remain unchanged.
@ncooke3 ncooke3 added this to the Firebase 12 - M167 milestone Jun 27, 2025
@ncooke3 ncooke3 requested a review from paulb777 June 30, 2025 18:26
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 30, 2025

@paulb777 , sorry, just happened to re-request your review right as you posted it.

@ncooke3 ncooke3 merged commit 5487ba1 into main Jun 30, 2025
365 of 369 checks passed
@ncooke3 ncooke3 deleted the fix/strict-patch-internal-dependencies branch June 30, 2025 19:11
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 30, 2025

Merged. No CocoaPods related failures.

@firebase firebase locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants