Skip to content

[Firebase AI] Conform GroundingMetdata to Equatable #15137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

andrewheard
Copy link
Contributor

Added Equatable and Hashable conformance to GroundingMetadata and its transitively referenced types. See firebase/quickstart-ios#1724 (comment) for context. This is also considered a general good practice from Apple:

Conforming to the Equatable and Hashable protocols is straightforward and makes it easier to use your own types in Swift. It’s a good idea for all your custom model types to conform.
-- https://developer.apple.com/documentation/swift/adopting-common-protocols

Jules Prompt

Add Equatable and Hashable conformance to GroundingMetadata. You will need to add the conformances to all of the types that GroundingMetadata transitively references.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the prompt!

@andrewheard
Copy link
Contributor Author

cc: @paulb777 to make sure you don't do this too.

Also self-reminder to delete https://github.com/firebase/quickstart-ios/blob/979388a9680d41114dfd9f74d52ba5fd8c148e13/firebaseai/ChatExample/Models/ChatMessage.swift#L34-L38 (and bump the minimum version of the firebase-ios-sdk dependency to 12.1) after the next release.

@andrewheard andrewheard merged commit 12582dd into main Jul 22, 2025
47 checks passed
@andrewheard andrewheard deleted the add-equatable-hashable-to-groundingmetadata branch July 22, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants