Skip to content

Conversation

srushtisv
Copy link
Contributor

@srushtisv srushtisv commented Aug 18, 2025

Adding integration tests for Passkeys

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@srushtisv srushtisv self-assigned this Aug 18, 2025
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@srushtisv srushtisv changed the title integration tests for passkeys SwiftAPI Tests in Authentication Example for Passkey Aug 18, 2025
@srushtisv srushtisv marked this pull request as ready for review August 18, 2025 17:07
@srushtisv srushtisv requested a review from pashanka August 18, 2025 17:34
Copy link
Contributor

@pashanka pashanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me.

}

@available(iOS 15.0, macOS 12.0, tvOS 16.0, *)
func DRAFTtestUnenrollPasskeySuccess() async throws {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this test as we won't be able to run it anytime soon. Thanks for trying out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Pavan, removed it.

"credentialId": testCredentialId,
"name": testPasskeyName,
]]
// Fake PasskeyInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change in formatting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting changes are done automatically by running ./scripts/style.sh. The manual change here was adding an if block to ensure this test does not run on visionOS, I was mainly trying to resolve the github check failure.

@srushtisv srushtisv merged commit f905d64 into passkey-end-to-end-ui-tests Aug 25, 2025
45 of 49 checks passed
@srushtisv srushtisv deleted the passkey-integration-tests-sv branch August 25, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants