-
Notifications
You must be signed in to change notification settings - Fork 949
Increase unit test coverage for oauth.ts to 100% #9140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (ab5c2a0) and merge commit (653955c).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (ab5c2a0) and merge commit (653955c).Test Logs |
@@ -23,7 +23,7 @@ env: | |||
# the behavior to use the new URLs. | |||
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/ | |||
CHROMEDRIVER_CDNBINARIESURL: https://storage.googleapis.com/chrome-for-testing-public | |||
CHROME_VALIDATED_VERSION: linux-120.0.6099.71 | |||
CHROME_VALIDATED_VERSION: linux-137.0.7151.119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also update https://github.com/firebase/firebase-js-sdk/blob/main/.github/workflows/test-all.yml#L26 to have the same version.
Discussion
Testing