-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MCP] Update descriptions of the consult_assistant tool #8915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c7efb2
Update descriptions of consult_assistant
fredzqm 957d4a5
Merge branch 'master' into fz/assistant-prompt
fredzqm 4240162
Merge branch 'master' into fz/assistant-prompt
fredzqm 8e19caf
Merge branch 'master' into fz/assistant-prompt
fredzqm 6fe14cf
Merge branch 'master' into fz/assistant-prompt
fredzqm a2b859c
Merge branch 'master' into fz/assistant-prompt
fredzqm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,18 @@ export const consult_assistant = tool( | |
{ | ||
name: "consult_assistant", | ||
description: | ||
"Send a question to an AI assistant specifically enhanced to answer Firebase questions.", | ||
"Access an AI assistant specialized in all aspects of **Firebase**. " + | ||
"Use this tool to get **detailed information**, **best practices**, **troubleshooting steps**, **code examples**, and **contextual help** regarding Firebase services, features, and project configuration. " + | ||
"This includes questions about Firestore, Authentication, Cloud Functions, Hosting, Storage, Analytics, and more. " + | ||
"It can also provide insights based on the **current Firebase project context**.", | ||
inputSchema: z.object({ | ||
prompt: z | ||
.string() | ||
.describe("A description of what the user is trying to do or learn with Firebase."), | ||
.describe( | ||
"The specific question or task related to Firebase. " + | ||
"Be precise and include relevant details, such as the Firebase service in question, the desired outcome, or any error messages encountered. " + | ||
"Examples: 'What's the best way to deploy a React app to Firebase Hosting?', 'Explain Firebase Authentication with Google Sign-In.' , 'What are the current project settings for 'projectId'? ", | ||
), | ||
Comment on lines
+17
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the Additionally, this change corrects a minor formatting inconsistency in the list of examples:
.describe(
[
"The specific question or task related to Firebase.",
"Be precise and include relevant details, such as the Firebase service in question, the desired outcome, or any error messages encountered.",
"Examples: 'What's the best way to deploy a React app to Firebase Hosting?', 'Explain Firebase Authentication with Google Sign-In.', 'What are the current project settings for \'projectId\'?'",
].join(" ")
), |
||
}), | ||
annotations: { | ||
title: "Consult Firebase Assistant", | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved readability and maintainability, consider using an array of strings joined together instead of direct string concatenation. This approach is often cleaner, less error-prone (e.g., forgetting a trailing space), and makes it easier to manage individual parts of the description.