Skip to content

Add product_init_mcp and fix param of product_init #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2025
Merged

Add product_init_mcp and fix param of product_init #8928

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2f39a8c
Fix the products_initialized GA stats
fredzqm Aug 2, 2025
a05a5df
move into init
fredzqm Aug 2, 2025
6ce37d6
Merge branch 'master' into fz/products_initialized
fredzqm Aug 3, 2025
1c05507
Merge branch 'master' into fz/products_initialized
fredzqm Aug 4, 2025
f35997b
Merge branch 'master' into fz/products_initialized
fredzqm Aug 4, 2025
1fe09b2
add product_init_mcp
fredzqm Aug 6, 2025
4b94b25
m
fredzqm Aug 6, 2025
8c7e0b2
m
fredzqm Aug 6, 2025
27b45c6
Merge branch 'master' into fz/products_initialized
fredzqm Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@

const setup: Setup = {
config: config.src,
rcfile: config.readProjectFile(".firebaserc", {

Check warning on line 192 in src/commands/init.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe assignment of an `any` value
json: true,
fallback: {},
}),
Expand Down Expand Up @@ -249,6 +249,7 @@
setup.features = setup.features.filter((f) => f !== "hosting:github");
}

const productsInitialized = setup.features?.join(",") || "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this is correct, the optional chaining (?.) and the fallback to an empty string (|| "") are redundant here.

Based on the control flow in this function:

  • setup.features is assigned a value at either line 209 or 211.
  • The check at line 229 ensures that setup.features is a non-empty array, otherwise an error is thrown.

Therefore, setup.features is guaranteed to be a string[] with at least one element at this point, so you can safely call .join(',') directly. This makes the code slightly cleaner.

Suggested change
const productsInitialized = setup.features?.join(",") || "";
const productsInitialized = setup.features.join(",");

await init(setup, config, options);

logger.info();
Expand All @@ -257,9 +258,9 @@
if (!fsutils.fileExistsSync(config.path(".gitignore"))) {
config.writeProjectFile(".gitignore", GITIGNORE_TEMPLATE);
}
const duration = Math.floor((process.uptime() - start) * 1000);

await trackGA4("product_init", { products_initialized: setup.features?.join(",") }, duration);
const duration = Math.floor((process.uptime() - start) * 1000);
await trackGA4("product_init", { products_initialized: productsInitialized }, duration);

logger.info();
utils.logSuccess("Firebase initialization complete!");
Expand Down
Loading