Skip to content

Conversation

andrewheard
Copy link
Contributor

Added a target and scheme that does not have the SPM dependency included for FirebaseAI. This allows us to test the zip build from the firebase-ios-sdk repo.

Copy link

Summary of Changes

Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase AI example project by introducing a new build configuration. It adds a dedicated Xcode target and scheme, FirebaseAIExampleZip, which is specifically tailored to facilitate testing of the Firebase AI SDK when integrated as a zip build, rather than through Swift Package Manager. This ensures comprehensive testing coverage for different distribution methods of the SDK, allowing for validation of the example app's functionality under a zip-based integration scenario.

Highlights

  • New Xcode Target Added: A new Xcode target named FirebaseAIExampleZip has been introduced to the project configuration.
  • New Xcode Scheme Created: A corresponding Xcode scheme, FirebaseAIExampleZip.xcscheme, has been added to define how this new target is built, run, and tested.
  • Purpose for Zip Testing: This new target and scheme are specifically designed to enable testing of the Firebase AI example application when the Firebase AI SDK is integrated via a zip distribution, explicitly bypassing its Swift Package Manager dependency.
  • Dependency Configuration: The FirebaseAIExampleZip target is configured with its own set of build phases, including all necessary source files, resources, and framework dependencies such as MarkdownUI and GenerativeAIUIComponents.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new FirebaseAIExampleZip target and scheme to test the zip distribution build. The changes are primarily within the Xcode project configuration. I've identified a critical issue where the new target shares the same bundle identifier as the existing one, which will lead to installation conflicts. Additionally, there's a minor inconsistency in the product name for the new target that should be addressed for better maintainability. Addressing these points will ensure the project configuration is correct and robust.

@paulb777
Copy link
Member

Probably not a big deal, but may be slightly confusing to quickstart users to see a selectable scheme that won't work without copying the zip in.

How about making sure https://github.com/firebase/quickstart-ios/blob/main/firebaseai/README.md makes it clear which scheme to select?

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever to add a scheme!

@ncooke3
Copy link
Member

ncooke3 commented Sep 29, 2025

@paulb777's when my WIP PRs are done. This extra scheme can be deleted in favor of a script that can remove the SPM dependency and swap in XCFrameworks.

@paulb777
Copy link
Member

OK, then I'm fine with this for the short term

@andrewheard
Copy link
Contributor Author

andrewheard commented Sep 29, 2025

Probably not a big deal, but may be slightly confusing to quickstart users to see a selectable scheme that won't work without copying the zip in.

How about making sure main/firebaseai/README.md makes it clear which scheme to select?

Good idea, @paulb777. Added a note in the README to select the FirebaseAIExample (iOS) scheme since I can't include the zip artifacts (unsigned) and can't provide instructions to use the zip (not yet released). (And as @ncooke3 said, we should remove this once the WIP PRs are done.)

@andrewheard andrewheard merged commit e5a50c1 into main Sep 29, 2025
7 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-qs-zip-test branch September 29, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants