-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Firebase AI] Add FirebaseAIExampleZip
scheme for zip testing
#1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase AI example project by introducing a new build configuration. It adds a dedicated Xcode target and scheme, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new FirebaseAIExampleZip
target and scheme to test the zip distribution build. The changes are primarily within the Xcode project configuration. I've identified a critical issue where the new target shares the same bundle identifier as the existing one, which will lead to installation conflicts. Additionally, there's a minor inconsistency in the product name for the new target that should be addressed for better maintainability. Addressing these points will ensure the project configuration is correct and robust.
Probably not a big deal, but may be slightly confusing to quickstart users to see a selectable scheme that won't work without copying the zip in. How about making sure https://github.com/firebase/quickstart-ios/blob/main/firebaseai/README.md makes it clear which scheme to select? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever to add a scheme!
@paulb777's when my WIP PRs are done. This extra scheme can be deleted in favor of a script that can remove the SPM dependency and swap in XCFrameworks. |
OK, then I'm fine with this for the short term |
Good idea, @paulb777. Added a note in the README to select the |
Added a target and scheme that does not have the SPM dependency included for
FirebaseAI
. This allows us to test the zip build from thefirebase-ios-sdk
repo.