Skip to content

Value type components #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Value type components #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7660bc
Increase family limit from 8 components to 16 components
stackotter Jan 27, 2022
ad7349a
Initial changes to convert components to value types
stackotter Mar 26, 2022
4cd8a1a
Update project with current master
ctreffs Oct 11, 2024
159223f
Merge branch 'master' into value-type-components
ctreffs Oct 11, 2024
6e871b5
Update CI
ctreffs Oct 11, 2024
f16264c
Merge branch 'value-type-components' of github.com:stackotter/ecs int…
ctreffs Oct 11, 2024
71cfcf1
Merge branch 'master' into value-type-components
ctreffs Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ on:
- .github/workflows/documentation.yml
- Sources/FirebladeECS/**.swift
workflow_dispatch:
branches: [ master ]
paths:
- .github/workflows/documentation.yml
- Sources/FirebladeECS/**.swift

jobs:
build:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/markdown-link-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Check markdown links

on: push
on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
workflow_dispatch:

jobs:
markdown-link-check:
Expand Down
2 changes: 1 addition & 1 deletion Sources/FirebladeECS/Component.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/// **Component**
///
/// A component represents the raw data for one aspect of an entity.
public protocol Component: AnyObject {
public protocol Component {
/// Unique, immutable identifier of this component type.
static var identifier: ComponentIdentifier { get }

Expand Down
2 changes: 1 addition & 1 deletion Sources/FirebladeECS/Entity+Component.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ extension Entity {
self.remove(Comp.self)
return
}
if self.get(component: componentType) === newComponent {
if self.get(component: componentType) != nil {
return
}
self.assign(newComponent)
Expand Down
Loading