Skip to content

Conversation

@ctreffs
Copy link
Member

@ctreffs ctreffs commented Oct 14, 2024

Description

  • Integrated benchmark as CI step
  • Commit benchmark results into PR

Checklist

  • I've read the Contribution Guidelines
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (to the extent possible).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.
  • I've updated the documentation (if appropriate).

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (9708eba) to head (25a60f1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          24       24           
  Lines        1435     1435           
=======================================
  Hits         1395     1395           
  Misses         40       40           

@ctreffs ctreffs added the benchmark Run benchmarks label Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@ctreffs ctreffs removed the benchmark Run benchmarks label Oct 14, 2024
@ctreffs ctreffs added the benchmark Run benchmarks label Oct 14, 2024
@ctreffs ctreffs added benchmark Run benchmarks and removed benchmark Run benchmarks labels Oct 14, 2024
@heckj
Copy link
Contributor

heckj commented Oct 21, 2024

in case you want the references, MahdiBM recently tossed up a couple of gists for comparing and noting benchmark changes on PRs, incuding all this GH Action setup, if that's useful as a backstop:

I noted them down for doing something similar myself on a couple of projects.

@ctreffs
Copy link
Member Author

ctreffs commented Oct 22, 2024

in case you want the references, MahdiBM recently tossed up a couple of gists for comparing and noting benchmark changes on PRs, incuding all this GH Action setup, if that's useful as a backstop:

I noted them down for doing something similar myself on a couple of projects.

Thanks a lot, that's exactly what was going on in my mind 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Run benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants