add sql server quote-wrapping #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds SQLserver logic to the
wrap_in_quotes()macro. this was necessary as the default logic (using backticks instead of double quotes) did not work with sql server in the Fivetran Platform packagefor the time being, i have excluded the
drop_schemas_automationrun for sqlserver to get around the error.If this PR introduces a new macro, how did you test the new macro?
In Buildkite, where it is called in the
drop_schemas_automationmacroIf this PR introduces a modification to an existing macro, which packages is the macro currently present in and what steps were taken to test compatibility across packages?
added sqlserver adapter version of the macro only, and it does not reference any other macros.
Did you update the README to reflect the macro addition/modifications?