Skip to content

add logrotate out plugin (#2) #10824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add logrotate out plugin (#2) #10824

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d26d5e8
add logrotate out plugin (#2)
SagiROosto Sep 3, 2025
cbf7b88
update fluent auto CR comments
SagiROosto Sep 4, 2025
201d5a3
match logrotate to out_file in cmakes (#3)
SagiROosto Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/plugins_options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ DEFINE_OPTION(FLB_OUT_DATADOG "Enable DataDog output plugin"
DEFINE_OPTION(FLB_OUT_ES "Enable Elasticsearch output plugin" ON)
DEFINE_OPTION(FLB_OUT_EXIT "Enable Exit output plugin" ON)
DEFINE_OPTION(FLB_OUT_FILE "Enable file output plugin" ON)
DEFINE_OPTION(FLB_OUT_LOGROTATE "Enable logrotate output plugin" ON)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this build for all targets including macOS and Windows? They may need configuring via their specific cmake/ config files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logrotate plugin is actually a fork of the out_file with gzip and couple of move/copy files.
I've matched all cmakes to be the same as the out_file

DEFINE_OPTION(FLB_OUT_FLOWCOUNTER "Enable flowcount output plugin" ON)
DEFINE_OPTION(FLB_OUT_FORWARD "Enable Forward output plugin" ON)
DEFINE_OPTION(FLB_OUT_GELF "Enable GELF output plugin" ON)
Expand Down
21 changes: 21 additions & 0 deletions conf/fluent-bit-logrotate.conf
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide a YAML version too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I didn't see other configs. let me know where can I put it. anyway in fluent-bit-docs I'll list both options

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[SERVICE]
Flush 1
Log_Level info
Parsers_File parsers.conf

[INPUT]
Name dummy
Tag test.logrotate
Dummy {"message": "test log message", "level": "info"}
Rate 10

[OUTPUT]
Name logrotate
Match test.logrotate
Path /tmp/logs
File test.log
Format json
Max_Size 10M
Max_Files 5
Gzip On
Mkdir On
5 changes: 5 additions & 0 deletions plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,11 @@ REGISTER_OUT_PLUGIN("out_datadog")
REGISTER_OUT_PLUGIN("out_es")
REGISTER_OUT_PLUGIN("out_exit")
REGISTER_OUT_PLUGIN("out_file")

if(FLB_OUT_LOGROTATE)
REGISTER_OUT_PLUGIN("out_logrotate")
endif()

REGISTER_OUT_PLUGIN("out_forward")
REGISTER_OUT_PLUGIN("out_http")
REGISTER_OUT_PLUGIN("out_influxdb")
Expand Down
5 changes: 5 additions & 0 deletions plugins/out_logrotate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
set(src
logrotate.c)

find_package(ZLIB REQUIRED)
FLB_PLUGIN(out_logrotate "${src}" "${ZLIB_LIBRARIES}")
Loading
Loading